slinkydeveloper commented on pull request #18847: URL: https://github.com/apache/flink/pull/18847#issuecomment-1047912215
> I think it is better to adapt @Rule and @ClassRule in Junit 5 when refactoring. > To be honest, I don't understand why the MiniClusterResource is used as a @Rule to start and end a mini cluster for every test cases. Exactly my point on why I didn't added this feature here. It doesn't seem there are much tests doing that, and probably most of the ones that are doing it, are doing it by mistake. I would rather not add the capability in this PR. If it's really needed, we add it in future, but now as default this extension always starts only one cluster per class. Another aspect is that if you really need to create a cluster per method, then just manually instantiating `MiniCluster` should be enough, and you don't need the extension doing it for you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
