[
https://issues.apache.org/jira/browse/FLINK-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422399#comment-15422399
]
ASF GitHub Bot commented on FLINK-4309:
---------------------------------------
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2371
Changes look good all in all. Could you also add a
`org.apache.flink.util.Preconditions.checkNotNull` check for the backing config
in the constructor?
> Potential null pointer dereference in DelegatingConfiguration#keySet()
> ----------------------------------------------------------------------
>
> Key: FLINK-4309
> URL: https://issues.apache.org/jira/browse/FLINK-4309
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Sunny T
> Priority: Minor
>
> {code}
> final int prefixLen = this.prefix == null ? 0 : this.prefix.length();
> for (String key : this.backingConfig.keySet()) {
> if (key.startsWith(this.prefix)) {
> {code}
> If this.prefix == null, we would get NPE in startsWith():
> {code}
> public boolean startsWith(String prefix, int toffset) {
> char ta[] = value;
> int to = toffset;
> char pa[] = prefix.value;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
