[ https://issues.apache.org/jira/browse/FLINK-26136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497184#comment-17497184 ]
Aitozi commented on FLINK-26136: -------------------------------- Hi [~gyfora], I have a doubt for this issue. I think the webhook will intercept the request of CREATE and UPDATE of the FlinkDeployments. If we apply the update to a FlinkDeployment, it will first validate by webhook, then reconcile by the flink-kubernetes-operator. So do we need to share the validation with the flink-kubernetes-operator ? > Implement shared validation logic for FlinkDeployment objects > ------------------------------------------------------------- > > Key: FLINK-26136 > URL: https://issues.apache.org/jira/browse/FLINK-26136 > Project: Flink > Issue Type: Sub-task > Components: Kubernetes Operator > Reporter: Gyula Fora > Assignee: Gyula Fora > Priority: Major > > At the moment there is only a very basic “placeholder” validation logic > implemented in the webhook module: > org.apache.flink.kubernetes.operator.admission.FlinkDeploymentValidator > We should aim to validate parts of the FlinkDeployment that can be done > upfront, things like most common Flink config options, parallelism, resources > etc. > As described in https://issues.apache.org/jira/browse/FLINK-26135 this > validation should be part of the flink-kubernetes-operator module. -- This message was sent by Atlassian Jira (v8.20.1#820001)