1996fanrui commented on pull request #18852: URL: https://github.com/apache/flink/pull/18852#issuecomment-1050574741
> @1996fanrui , thanks a lot for these changes. I left a several comments in the PR, please, take a look. I also have an one question: According to ticket, you had a problem with `flink won't execute the tolerable-failed-checkpoints logic. ` but as I see you didn't make any fix for that. Do I understand correctly, that you had such a problem because you have the old version of Flink but right now(with the master) it is not a problem anymore? Hi @akalash , thanks for your review. Yeah, you are right. I have replied in JIRA that `our prod env use Flink 1.13. I see some jiras have resolved this issue.`, so I just fixed another problems. https://issues.apache.org/jira/browse/FLINK-23189 and https://issues.apache.org/jira/browse/FLINK-24344 I will address your comments and resubmit this PR as soon as possible. Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
