[GitHub] [flink] matriv commented on a change in pull request #18908: [FLINK-26075][table-api][table-planner] Persist and use node configuration

[GitBox]

matriv commented on a change in pull request #18908:
URL: https://github.com/apache/flink/pull/18908#discussion_r814660563



##########
File path: 
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/serde/TemporalTableSourceSpecSerdeTest.java
##########
@@ -59,16 +58,11 @@
 /** Tests for {@link TemporalTableSourceSpec} serialization and 
deserialization. */
 @Execution(CONCURRENT)
 public class TemporalTableSourceSpecSerdeTest {
+
     private static final FlinkTypeFactory FACTORY = 
FlinkTypeFactory.INSTANCE();
 
     private static final FlinkContext FLINK_CONTEXT =
-            new FlinkContextImpl(
-                    false,
-                    TableConfig.getDefault(),
-                    new ModuleManager(),
-                    null,
-                    CatalogManagerMocks.createEmptyCatalogManager(),
-                    null);
+            PlannerMocks.create().getPlannerContext().getFlinkContext();

Review comment:
       but the `TableSourceTable` needs currently a context




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org