[GitHub] [flink] dannycranmer commented on a change in pull request #18945: [FLINK-26417][connector/base] Add failed Inflight requests in async writer snapshot state

[GitBox]

dannycranmer commented on a change in pull request #18945:
URL: https://github.com/apache/flink/pull/18945#discussion_r816931499



##########
File path: 
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##########
@@ -51,7 +52,8 @@
  */
 @PublicEvolving
 public abstract class AsyncSinkWriter<InputT, RequestEntryT extends 
Serializable>
-        implements StatefulSink.StatefulSinkWriter<InputT, 
BufferedRequestState<RequestEntryT>> {
+        implements StatefulSink.StatefulSinkWriter<InputT, 
BufferedRequestState<RequestEntryT>>,
+                TwoPhaseCommittingSink.PrecommittingSinkWriter<InputT, Void> {

Review comment:
       But `flush` is not blocking so after calling `flush` there will still be 
requests in flight, right? Am I missing something?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org