Myasuka commented on a change in pull request #18931:
URL: https://github.com/apache/flink/pull/18931#discussion_r817353818



##########
File path: 
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/RetryingExecutor.java
##########
@@ -172,16 +225,19 @@ private RetriableTask next() {
                     actionCompleted,
                     runnable,
                     retryPolicy,
-                    executorService,
-                    attemptsPerTaskHistogram);
+                    blockingExecutor,
+                    attemptsPerTaskHistogram,
+                    scheduler,
+                    failureCallback,
+                    activeAttempts);
         }
 
         private Optional<ScheduledFuture<?>> scheduleTimeout() {
             long timeout = retryPolicy.timeoutFor(current);
             return timeout <= 0
                     ? Optional.empty()
                     : Optional.of(
-                            executorService.schedule(
+                            scheduler.schedule(

Review comment:
       Thanks for your explaination.
   
   I did not get the idea that why we does not interrupt the timeout attempt in 
test? I can see the tasks would be failed in `BatchingStateChangeUploader` if 
timedout.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to