JingsongLi commented on a change in pull request #29: URL: https://github.com/apache/flink-table-store/pull/29#discussion_r817368776
########## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/RollingFile.java ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.store.file.utils; + +import org.apache.flink.api.common.serialization.BulkWriter; +import org.apache.flink.core.fs.FSDataOutputStream; +import org.apache.flink.core.fs.FileSystem; +import org.apache.flink.core.fs.Path; +import org.apache.flink.table.data.RowData; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.util.Iterator; +import java.util.List; + +/** A utility class to write a list of objects into several files, each with a size limit. */ +public class RollingFile { + + /** + * Provide logic for serializing records and producing file metas. + * + * @param <R> record type + * @param <F> file meta type + */ + public interface Context<R, F> { Review comment: Actually, this context also contains the statistics of the information. It is stateful class. What about a `RollingFile` and `FileWriter`? `FileWriter` is only responsible for writing single file. ########## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/utils/RollingFile.java ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.store.file.utils; + +import org.apache.flink.api.common.serialization.BulkWriter; +import org.apache.flink.core.fs.FSDataOutputStream; +import org.apache.flink.core.fs.FileSystem; +import org.apache.flink.core.fs.Path; +import org.apache.flink.table.data.RowData; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.util.Iterator; +import java.util.List; + +/** A utility class to write a list of objects into several files, each with a size limit. */ +public class RollingFile { + + /** + * Provide logic for serializing records and producing file metas. + * + * @param <R> record type + * @param <F> file meta type + */ + public interface Context<R, F> { + + /** Create the path for a new file. */ + Path newPath(); + + /** Create a new object writer. */ + BulkWriter<RowData> newWriter(FSDataOutputStream out) throws IOException; + + /** + * Called before writing a record into file. Per-record calculation can be performed here. + * + * @param record record to write + * @return serialized record + */ + RowData serialize(R record); Review comment: `toRowData` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
