XComp opened a new pull request #18963:
URL: https://github.com/apache/flink/pull/18963


   ## What is the purpose of the change
   
   `FileStateHandle.discardState` didn't handle cases where the `FileSystem` 
implementation used the return value to indicate an error during deletion. This 
made the cleanup logic not recognize the failure.
   
   ## Brief change log
   
   * Updates `FileStateHandle.discardState` implementation
   
   ## Verifying this change
   
   * Introduces `TestingFileSystem`
   * Adds tests to `FileStateHandleTest` to cover both deletion code paths.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: yes
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to