Github user mxm commented on the issue:

    https://github.com/apache/flink/pull/2114
  
    Hi @thormanrd! Thanks for your PR. As Robert and Stephan already pointed 
out, it contains a lot of reformats which are generally encouraged. They make 
the pull request's essentials hard to review and can even introduce subtle 
bugs. 
    
    The prefered way of syncing up with the master is to rebased against the 
master before you open a pull request:
    
    ```
    git pull --rebase upstream master
    ``` 
    `upstream` is the main Flink repository. Maybe it's called `origin` in your 
case. Check using `git remote -v`.
    
    After the pull request has been opened you should only push additional 
commits (no rebasing) to keep the comments and discussion. In the end, either 
you or the committer rebases again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to