smattheis commented on a change in pull request #18991:
URL: https://github.com/apache/flink/pull/18991#discussion_r820763673
##########
File path: docs/content.zh/docs/ops/metrics.md
##########
@@ -1428,6 +1428,16 @@ Note that the metrics are only available via reporters.
<td>Maximum recorded duration of a single consecutive period of the task
being in the hard back pressure state in the last sampling period. Please check
softBackPressuredTimeMsPerSecond and hardBackPressuredTimeMsPerSecond for more
information.</td>
<td>Gauge</td>
</tr>
+ <tr>
Review comment:
That would see it as meaningful. I didn't want to extend the scope too
much as the issue's scope is already extended with the throughput but I would
be +1 for it. Although I need to check if this feasible in an easy way.
Counting (which methods need to inc and dec as it's not fully trivial with the
createBatch semantics) vs. size method (what interval? how to do that with a
metrics class? also note that size() is marked @VisibleForTesting and acquires
a lock).
What do you think should we invest the effort now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
