matriv commented on a change in pull request #18980:
URL: https://github.com/apache/flink/pull/18980#discussion_r822599085
##########
File path:
flink-table/flink-table-api-scala-bridge/src/main/scala/org/apache/flink/table/api/bridge/scala/internal/StreamTableEnvironmentImpl.scala
##########
@@ -292,6 +294,12 @@ class StreamTableEnvironmentImpl (
object StreamTableEnvironmentImpl {
+ def create(
+ executionEnvironment: StreamExecutionEnvironment,
+ settings: EnvironmentSettings): StreamTableEnvironmentImpl =
+ create(executionEnvironment, settings, TableConfig.getDefault)
+
+ @VisibleForTesting
Review comment:
It's only used by `OverAggregateHarnessTest` because of the "weird"
testing with a custom `TestTableConfig` class to explicitly set
`maxIdleStateRetentionTime`, overriding the default calculation on the original
`TableConfig`. Haven't thought of a workaround to avoid this, any suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
