XComp commented on a change in pull request #18987:
URL: https://github.com/apache/flink/pull/18987#discussion_r822634591



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/FileSystemJobResultStore.java
##########
@@ -165,8 +171,16 @@ public boolean hasCleanJobResultEntryInternal(JobID jobId) 
throws IOException {
 
     @Override
     public Set<JobResult> getDirtyResultsInternal() throws IOException {
+        final FileStatus[] statuses = fileSystem.listStatus(this.basePath);
+        if (statuses == null) {
+            LOG.warn(
+                    "The JobResultStore directory '"
+                            + basePath
+                            + "' was deleted. No persisted JobResults could be 
recovered.");
+            return Collections.emptySet();

Review comment:
       because it's an unexpected state of Flink which might lead to weird 
behavior. Some FileSystems would complain about a missing directory whereas 
other filesystem might allow to create a file within this directory anyway 
(e.g. object stores?)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to