LadyForest commented on a change in pull request #40:
URL: https://github.com/apache/flink-table-store/pull/40#discussion_r823428099
##########
File path:
flink-table-store-connector/src/test/java/org/apache/flink/table/store/connector/source/FileStoreSourceSplitReaderTest.java
##########
@@ -64,32 +67,92 @@ public static void after() {
}
@Test
- public void testKeyAsRecord() throws Exception {
- innerTestOnce(true);
+ public void testPrimaryKey() throws Exception {
+ innerTestOnce(false, 0);
+ }
+
+ @Test
+ public void testValueCount() throws Exception {
+ innerTestOnce(true, 0);
Review comment:
Correct me if I'm wrong. I'm a little confused that`innerTestOnce`
relies on `TestDataReadWrite`. But the latter hardcoded the key type, value
type, and accumulator type to the pk situation. How does it work to test the
value count(no pk) condition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
