zentol commented on a change in pull request #18905:
URL: https://github.com/apache/flink/pull/18905#discussion_r823500652
##########
File path: flink-connectors/flink-sql-connector-aws-kinesis-streams/pom.xml
##########
@@ -36,6 +36,12 @@
<groupId>org.apache.flink</groupId>
<artifactId>flink-connector-aws-kinesis-streams</artifactId>
<version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.flink</groupId>
+
<artifactId>flink-connector-base</artifactId>
Review comment:
should be unncessary because the only remaining transitive Flink
dependency after shading is flink-table-common
##########
File path: flink-connectors/flink-sql-connector-aws-kinesis-firehose/pom.xml
##########
@@ -36,6 +36,12 @@
<groupId>org.apache.flink</groupId>
<artifactId>flink-connector-aws-kinesis-firehose</artifactId>
<version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.flink</groupId>
+
<artifactId>flink-connector-base</artifactId>
Review comment:
should be unncessary because the only remaining transitive Flink
dependency after shading is flink-table-common
##########
File path: flink-connectors/flink-sql-connector-kinesis/pom.xml
##########
@@ -40,6 +40,12 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-connector-kinesis</artifactId>
<version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.flink</groupId>
+
<artifactId>flink-connector-base</artifactId>
Review comment:
should be unncessary because there are no remaining transitive Flink
dependencies after shading
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-aws-kinesis-streams/pom.xml
##########
@@ -65,6 +65,13 @@
<artifactId>jackson-databind</artifactId>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-aws-base</artifactId>
Review comment:
same question as for firehose. Since they don't use the connector
directly (but add the sql-connector jar to the jobs classpath) it shouldn't be
needed.
##########
File path: flink-table/flink-sql-client/pom.xml
##########
@@ -73,6 +73,13 @@ under the License.
<!-- test dependencies -->
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
same question as for the csv-format
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-aws-kinesis-firehose/pom.xml
##########
@@ -51,6 +51,14 @@
<scope>test</scope>
<type>test-jar</type>
</dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-aws-base</artifactId>
Review comment:
its a bit weird that this is now (supposedly) required. Irrespective of
the changes made, aws-base wasn't on the classpath in the e2e test because so
far it only used test-jars which don't bring in transitive dependencies.
##########
File path: flink-table/flink-table-planner/pom.xml
##########
@@ -198,6 +198,13 @@ under the License.
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
same question as for the csv-format
##########
File path: flink-formats/flink-avro/pom.xml
##########
@@ -92,6 +92,13 @@ under the License.
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
same question as for the csv-format
##########
File path: flink-connectors/flink-sql-connector-pulsar/pom.xml
##########
@@ -40,6 +40,12 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-connector-pulsar</artifactId>
<version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.flink</groupId>
+
<artifactId>flink-connector-base</artifactId>
Review comment:
should be unncessary because there are no remaining transitive Flink
dependencies after shading
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/pom.xml
##########
@@ -156,6 +156,13 @@ under the License.
<version>${project.version}</version>
<type>test-jar</type>
</dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
same question as for firehose
##########
File path: flink-end-to-end-tests/flink-streaming-kinesis-test/pom.xml
##########
@@ -88,6 +88,13 @@ under the License.
<type>test-jar</type>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-aws-base</artifactId>
Review comment:
same question as for firehose
##########
File path: flink-formats/flink-csv/pom.xml
##########
@@ -76,6 +76,12 @@ under the License.
</dependency>
<!-- test dependencies -->
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
What needs this? There is no import in this module to any of the
classes, and everything else that might need it (be it a connector or format)
should bring their own version.
##########
File path: flink-connectors/flink-sql-connector-elasticsearch7/pom.xml
##########
@@ -40,6 +40,12 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-connector-elasticsearch7</artifactId>
<version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.flink</groupId>
+
<artifactId>flink-connector-base</artifactId>
Review comment:
should be unncessary because there are no remaining transitive Flink
dependencies after shading
##########
File path: flink-connectors/flink-sql-connector-rabbitmq/pom.xml
##########
@@ -68,6 +68,10 @@ under the License.
<pattern>com.rabbitmq</pattern>
<shadedPattern>org.apache.flink.rabbitmq.shaded.com.rabbitmq</shadedPattern>
</relocation>
+ <relocation>
+
<pattern>org.apache.flink.connector.base</pattern>
Review comment:
Why is this done in the sql connector, and not the connector itself?
##########
File path: flink-connectors/flink-sql-connector-elasticsearch6/pom.xml
##########
@@ -40,6 +40,12 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-connector-elasticsearch6</artifactId>
<version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.flink</groupId>
+
<artifactId>flink-connector-base</artifactId>
Review comment:
should be unncessary because there are no remaining transitive Flink
dependencies after shading
##########
File path: flink-yarn-tests/pom.xml
##########
@@ -41,6 +41,13 @@ under the License.
<!-- test dependencies -->
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
same question as for the csv-format
##########
File path: flink-examples/flink-examples-table/pom.xml
##########
@@ -93,6 +93,13 @@ under the License.
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
same question as for the csv-format
##########
File path: flink-examples/flink-examples-streaming/pom.xml
##########
@@ -80,6 +80,13 @@ under the License.
<!-- test dependencies -->
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
same question as for the csv-format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
