Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2377#discussion_r75322999
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/jobmaster/JobMaster.java
---
@@ -248,4 +374,40 @@ void
finishResourceManagerRegistration(ResourceManagerGateway resourceManager, I
public boolean isConnected() {
return resourceManager != null;
}
+
+
+ /**
+ * Cancel the current job and notify all listeners the job's
cancellation.
+ *
+ * @param cause Cause for the cancelling.
+ */
+ private void cancelAndClearEverything(Throwable cause) {
+ // currently, nothing to do here
+ }
+
+ //
------------------------------------------------------------------------
+ // Utility classes
+ //
------------------------------------------------------------------------
+ private class JobMasterLeaderContender implements LeaderContender {
--- End diff --
I'm not really decided here: Maybe we could let the JobMaster directly
implement the LeaderContender interface. Then we could get rid of one layer of
indirection (basically the `grantJobMasterleadership`, the
`revokeJobMasterLeadership` and `onJobMasterElectionError` methods. Would that
make sense?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
