LadyForest commented on a change in pull request #41:
URL: https://github.com/apache/flink-table-store/pull/41#discussion_r825675632



##########
File path: 
flink-table-store-kafka/src/test/java/org/apache/flink/table/store/kafka/KafkaTableTestBase.java
##########
@@ -92,7 +92,6 @@ protected void doStart() {
     @Before
     public void setup() {
         env = StreamExecutionEnvironment.getExecutionEnvironment();
-        tEnv = StreamTableEnvironment.create(env);

Review comment:
       > But it contains `StreamExecutionEnvironment` and 
`StreamTableEnvironment`, it has inited `StreamExecutionEnvironment`, why no 
`StreamTableEnvironment`?
   
   cause I want to create `tEnv` conditionally according to junit parameter . 
Like
   ```java
   env.setRuntimeMode(executionMode);
   if (executionMode == STRAMING) {
       env.enableCheckpointing(100);
   }
   tEnv = StreamTableEnvironment.create(env);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to