[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426830#comment-15426830
]
ASF GitHub Bot commented on FLINK-4389:
---------------------------------------
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2363
Thanks for your contribution @zentol. I've gone over the code and made some
inline comments. My main concern/question is actually the representation of
metric's type and hierarchy information. I think that encoding it in a string
and then re-parsing it on the receiver side to reconstruct the information is
rather fragile and error-prone especially wrt maintainability. Maybe you can
give me some background why you decided to do it so.
Apart from that, I think the code contains many tests, which I really like
:-)
> Expose metrics to Webfrontend
> -----------------------------
>
> Key: FLINK-4389
> URL: https://issues.apache.org/jira/browse/FLINK-4389
> Project: Flink
> Issue Type: Sub-task
> Components: Metrics, Webfrontend
> Affects Versions: 1.1.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: pre-apache
>
>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-7%3A+Expose+metrics+to+WebInterface
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
