matriv commented on a change in pull request #19045:
URL: https://github.com/apache/flink/pull/19045#discussion_r827903597
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala
##########
@@ -477,40 +477,27 @@ object CodeGenUtils {
case Some(writer) =>
// use writer to set field
val writeField = binaryWriterWriteField(ctx, indexTerm, fieldTerm,
writer, fieldType)
- if (ctx.nullCheck) {
- s"""
- |${fieldExpr.code}
- |if (${fieldExpr.nullTerm}) {
- | ${binaryWriterWriteNull(indexTerm, writer, fieldType)};
- |} else {
- | $writeField;
- |}
- """.stripMargin
- } else {
- s"""
- |${fieldExpr.code}
- |$writeField;
- """.stripMargin
- }
+ s"""
+ |${fieldExpr.code}
+ |if (${fieldExpr.nullTerm}) {
+ | ${binaryWriterWriteNull(indexTerm, writer, fieldType)};
+ |} else {
+ | $writeField;
+ |}
+ """.stripMargin
case None =>
// directly set field to BinaryRowData, this depends on all the
fields are fixed length
val writeField = binaryRowFieldSetAccess(indexTerm, rowTerm,
fieldType, fieldTerm)
- if (ctx.nullCheck) {
- s"""
- |${fieldExpr.code}
- |if (${fieldExpr.nullTerm}) {
- | ${binaryRowSetNull(indexTerm, rowTerm, fieldType)};
- |} else {
- | $writeField;
- |}
- """.stripMargin
- } else {
- s"""
- |${fieldExpr.code}
- |$writeField;
- """.stripMargin
- }
+
+ s"""
Review comment:
Nope, this is directly returned (equivalent to java's `return "<the code
string>"`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
