Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75448874
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerJobMetricGroup.java
---
@@ -61,9 +58,7 @@ public TaskManagerJobMetricGroup(
JobID jobId,
@Nullable String jobName) {
- super(registry, jobId, jobName, scopeFormat.formatScope(parent,
jobId, jobName));
-
- this.parent = checkNotNull(parent);
+ super(registry, checkNotNull(parent), jobId, jobName,
scopeFormat.formatScope(parent, jobId, jobName));
--- End diff --
Ah ok, I see. Looking at the `formatScope` method, shouldn't rather the
method enforce the preconditions than the caller?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
