[
https://issues.apache.org/jira/browse/FLINK-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427960#comment-15427960
]
ASF GitHub Bot commented on FLINK-4431:
---------------------------------------
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/2390
[FLINK-4431] [core] Introduce a "VisibleForTesting" annotation.
This annotations declares that a function, field, constructor, or entire
type, is only visible for testing purposes.
This annotation is typically attached when for example a method should be
{@code private} (because it is not intended to be called externally), but
cannot be declared private, because some tests need to have access to it.
Guava offers a similar annotation, but I would like to not rely on Guava
for this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StephanEwen/incubator-flink
visible_testing_annotation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2390.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2390
----
commit 19fa1c6315750cbf001194300f4f7681e8be5e90
Author: Stephan Ewen <[email protected]>
Date: 2016-08-19T10:16:09Z
[FLINK-4431] [core] Introduce a "VisibleForTesting" annotation.
This annotation documents methods/fields that are not private because tests
need them,
but should not be called by any non-testing code.
----
> Introduce a "VisibleForTesting" annotation
> ------------------------------------------
>
> Key: FLINK-4431
> URL: https://issues.apache.org/jira/browse/FLINK-4431
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Reporter: Stephan Ewen
> Assignee: Stephan Ewen
> Priority: Minor
> Fix For: 1.2.0
>
>
> I suggest to introduce a {{VisibleForTesting}} annotation in the
> {{flink-annotations}} project.
> Adding this annotation to methods that are really only in place for testing
> is very useful feature. Currently, we depend on Guava for that. Having a
> guava dependency for a documentation annotation class seems a bit much.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
