Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2304#discussion_r75459165
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/BigDecParser.java ---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+package org.apache.flink.types.parser;
+
+import java.math.BigDecimal;
+import org.apache.flink.annotation.PublicEvolving;
+
+/**
+ * Parses a text field into a {@link java.math.BigDecimal}.
+ */
+@PublicEvolving
+public class BigDecParser extends FieldParser<BigDecimal> {
+
+ private static final BigDecimal BIG_DECIMAL_INSTANCE = BigDecimal.ZERO;
+
+ private BigDecimal result;
+
+ @Override
+ public int parseField(byte[] bytes, int startPos, int limit, byte[]
delimiter, BigDecimal reusable) {
+ int i = startPos;
+
+ final int delimLimit = limit - delimiter.length + 1;
+
+ while (i < limit) {
+ if (i < delimLimit && delimiterNext(bytes, i,
delimiter)) {
+ if (i == startPos) {
+
setErrorState(ParseErrorState.EMPTY_STRING);
+ return -1;
+ }
+ break;
+ }
+ i++;
+ }
+
+ if (i > startPos &&
+ (Character.isWhitespace(bytes[startPos]) ||
Character.isWhitespace(bytes[(i - 1)]))) {
+
setErrorState(ParseErrorState.NUMERIC_VALUE_ILLEGAL_CHARACTER);
+ return -1;
+ }
+
+ String str = new String(bytes, startPos, i - startPos);
--- End diff --
Instead of creating String instances, we could copy the relevant bytes into
a reusable `char[]` and create the `BigDecimal` with the `BigDecimal(char[] in,
int offset, int len)` constructor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
