XComp commented on a change in pull request #19121:
URL: https://github.com/apache/flink/pull/19121#discussion_r829137792
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/DefaultJobGraphStoreTest.java
##########
@@ -220,14 +221,23 @@ public void testGlobalCleanupWithNonExistName() throws
Exception {
.globalCleanupAsync(testingJobGraph.getJobID(),
Executors.directExecutor())
.join();
- try {
- removeFuture.get(timeout, TimeUnit.MILLISECONDS);
- fail(
- "We should get an expected timeout because we are removing
a non-existed job graph.");
- } catch (TimeoutException ex) {
- // expected
- }
- assertThat(removeFuture.isDone(), is(false));
+ removeFuture.join();
+ assertThat(removeFuture.isDone(), is(true));
Review comment:
You're right. The `removeFuture.join()` is not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
