LadyForest commented on a change in pull request #54:
URL: https://github.com/apache/flink-table-store/pull/54#discussion_r832789552
##########
File path:
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStore.java
##########
@@ -171,6 +183,35 @@ private FileStore buildFileStore() {
tableIdentifier, options, user, partitionType, keyType,
valueType, mergeFunction);
}
+ private void adjustIndexAndValidate() {
+ if (primaryKeys.length > 0 && partitions.length > 0) {
+ Set<Integer> pkSet =
Arrays.stream(primaryKeys).boxed().collect(Collectors.toSet());
Review comment:
> It is better to use List, because primary key and partition both have
the order.
I think only after pk and partition pass through the sanity check, the order
makes a difference.
When checking the super/subset relationship, the order doesn't matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
