[
https://issues.apache.org/jira/browse/FLINK-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430656#comment-15430656
]
ASF GitHub Bot commented on FLINK-3298:
---------------------------------------
Github user mushketyk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2314#discussion_r75667574
--- Diff:
flink-streaming-connectors/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/internal/AMQExceptionListener.java
---
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.connectors.activemq.internal;
+
+import org.slf4j.Logger;
+
+import javax.jms.ExceptionListener;
+import javax.jms.JMSException;
+
+public class AMQExceptionListener implements ExceptionListener {
+
+ private final boolean logFailuresOnly;
+ private final Logger logger;
+
+ public AMQExceptionListener(Logger logger, boolean logFailuresOnly) {
+ this.logger = logger;
+ this.logFailuresOnly = logFailuresOnly;
+ }
+
+
+ @Override
+ public void onException(JMSException e) {
+ if (logFailuresOnly) {
+ logger.error("Received ActiveMQ exception", e);
+ } else {
+ throw new RuntimeException("Received ActiveMQ
exception", e);
--- End diff --
Good point, I'll update the code accordingly. Should be a relatively minor
change.
> Streaming connector for ActiveMQ
> --------------------------------
>
> Key: FLINK-3298
> URL: https://issues.apache.org/jira/browse/FLINK-3298
> Project: Flink
> Issue Type: New Feature
> Components: Streaming Connectors
> Reporter: Mohit Sethi
> Assignee: Ivan Mushketyk
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
