zentol commented on a change in pull request #19263:
URL: https://github.com/apache/flink/pull/19263#discussion_r839376654



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
##########
@@ -380,6 +382,12 @@ public void register(Metric metric, String metricName, 
AbstractMetricGroup group
                 LOG.warn(
                         "Cannot register metric, because the MetricRegistry 
has already been shut down.");
             } else {
+                if (LOG.isDebugEnabled()) {
+                    LOG.debug(
+                            "Registering metric {}.{}.",
+                            
group.getLogicalScope(CharacterFilter.NO_OP_FILTER),
+                            metricName);
+                }

Review comment:
       That's more or less a convention of the metric system where we (for 
better or worse) try to reduce the impact if the system isn't used at all.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to