LB-Yu opened a new pull request #19300:
URL: https://github.com/apache/flink/pull/19300
## What is the purpose of the change
The `equals` method of `HBaseWriteOptions` uses `==` to determine whether
the `parallelism` of the Integer type is equal, which will cause problems.
The relevant code is as follows.
```java
private final Integer parallelism;
public boolean equals(Object o) {
....
return bufferFlushMaxSizeInBytes == that.bufferFlushMaxSizeInBytes
&& bufferFlushMaxRows == that.bufferFlushMaxRows
&& bufferFlushIntervalMillis ==
that.bufferFlushIntervalMillis
&& parallelism == that.parallelism;
}
```
In order to avoid similar problems, I refer to `HBaseLookupOptions` and use
`Objects.equals()` uniformly to judge whether the internal member variables are
equal.
## Brief change log
- *The `equals` method of `HBaseWriteOptions`*
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
