yunfengzhou-hub commented on a change in pull request #71: URL: https://github.com/apache/flink-ml/pull/71#discussion_r840405050
########## File path: flink-ml-benchmark/README.md ########## @@ -0,0 +1,169 @@ +# Flink ML Benchmark Getting Started + +This document provides instructions about how to run benchmarks on Flink ML's +stages in a Linux/MacOS environment. + +## Prerequisites + +### Installing Flink + +Please make sure Flink 1.14 or higher version has been installed in your local +environment. You can refer to the [local +installation](https://nightlies.apache.org/flink/flink-docs-master/docs/try-flink/local_installation/) +instruction on Flink's document website for how to achieve this. + +### Setting Up Flink Environment Variables + +After having installed Flink, please register `$FLINK_HOME` as an environment +variable into your local environment, and add `$FLINK_HOME` into your `$PATH` +variable. This can be completed by running the following commands in the Flink's +folder. + +```bash +export FLINK_HOME=`pwd` Review comment: It is difficult as we don't know user's environment and the Flink version users have installed. I tried using an example cmd, but it still means that users cannot directly copy and paste the commands without reading the instruction carefully. Please check if this is a proper implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
