LadyForest commented on a change in pull request #67: URL: https://github.com/apache/flink-table-store/pull/67#discussion_r841004556
########## File path: flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/TableStore.java ########## @@ -298,17 +316,26 @@ private FileStoreSource buildFileSource( } } - public DataStreamSource<RowData> build(StreamExecutionEnvironment env) { + public DataStreamSource<RowData> build() { + if (env == null) { + throw new IllegalArgumentException("Env should not be null."); Review comment: I think we'd better clarify the `Env` as`StreamExecutionEnvironment` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org