zhipeng93 commented on a change in pull request #73: URL: https://github.com/apache/flink-ml/pull/73#discussion_r841019214
########## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/feature/standardscaler/StandardScalerParams.java ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.feature.standardscaler; + +import org.apache.flink.ml.common.param.HasFeaturesCol; +import org.apache.flink.ml.common.param.HasPredictionCol; +import org.apache.flink.ml.param.BooleanParam; +import org.apache.flink.ml.param.Param; + +/** + * Params for {@link StandardScaler}. + * + * @param <T> The class type of this instance. + */ +public interface StandardScalerParams<T> extends HasFeaturesCol<T>, HasPredictionCol<T> { Review comment: Thanks for raising up this discussion. As `StandardScaler` is an `estmator`, it aims to train on the input features and predict on the output. So I thought it might be ok to keep the current naming. So soes `MinMaxScaler`. > HasFeaturesCol should probably be renamed to HasFeatureCol as it represents just one column. Here `features` is one column. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org