[
https://issues.apache.org/jira/browse/FLINK-4417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15433145#comment-15433145
]
ASF GitHub Bot commented on FLINK-4417:
---------------------------------------
GitHub user ramkrish86 opened a pull request:
https://github.com/apache/flink/pull/2407
FLINK-4417 Checkpoints should be subsumed by CheckpointID not, by timestamp
(Ram)
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
The Checkpointcoordinator#dropSubsumedCheckpoints() now works with the
Checkpoint id. Since we have changed to checkpoint id the condition is changed
from '<=' to '<'.
In JobManager.scala - the DeclineCheckpoint case was checking for true
condition - ideally it should be checking for false condition.
Feedback/review welcome. @StephanEwen- were you thinking some bigger change
than this?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ramkrish86/flink FLINK-4417
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2407.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2407
----
commit 158e03534c345f90568bdd92ce5a5d9569eaaf8a
Author: Ramkrishna <[email protected]>
Date: 2016-08-23T16:23:31Z
FLINK-4417 Checkpoints should be subsumed by CheckpointID not, by
timestamp (Ram)
----
> Checkpoints should be subsumed by CheckpointID not, by timestamp
> ----------------------------------------------------------------
>
> Key: FLINK-4417
> URL: https://issues.apache.org/jira/browse/FLINK-4417
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Affects Versions: 1.1.2
> Reporter: Stephan Ewen
> Assignee: ramkrishna.s.vasudevan
> Fix For: 1.2.0
>
>
> Since the system clocks cannot be expected to be stable/monotonous, the
> subsumption logic in the checkpoint coordinator should not decide which
> checkpoint is "newer" based on the system time.
> The checkpoint ID is guaranteed to be strictly monotonously increasing. It is
> a better measure to decide which checkpoint is newer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
