zentol commented on code in PR #4: URL: https://github.com/apache/flink-connector-elasticsearch/pull/4#discussion_r842567443
########## .github/workflows/ci.yml: ########## @@ -0,0 +1,60 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################ + +name: Build flink-connector-elasticsearch +on: [push, pull_request] +jobs: + compile_and_test: + runs-on: ubuntu-latest + strategy: + matrix: + jdk: [8, 11] + env: + MVN_GOALS: clean install Review Comment: By using `clean` in the test step you end up re-doing everything from the compile step. I think there are only 2 approaches that really make sense. 1) `mvn clean test-compile -T<parallelism> -> mvn install` 2) `mvn clean install` 1) `test-compile` only compiles the code but doesn't create jars. This is useful because it can be run in parallel, and jars are inevitable recreated in the install step anyway. To me this only makes sense if you have a good reason for this separation though. In Flink we do this because we have several test jobs to skip as much as possible from the compile phase; I don't see any gain for this project, but I also don't know what your plans are. On another note, consider only running `mvn verify` so you don't need to worry about snapshot artifacts ending up being cached in the maven repository. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
