zentol commented on code in PR #19351:
URL: https://github.com/apache/flink/pull/19351#discussion_r843115118


##########
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/IntermediateResultPartitionTest.java:
##########
@@ -296,10 +296,10 @@ private static IntermediateResult createResult(
         JobGraph jobGraph = JobGraphTestUtils.batchJobGraph(source, sink);
 
         SchedulerBase scheduler =
-                SchedulerTestingUtils.newSchedulerBuilder(
-                                jobGraph, 
ComponentMainThreadExecutorServiceAdapter.forMainThread())
-                        .setIoExecutor(executorService)
-                        .setFutureExecutor(executorService)
+                new SchedulerTestingUtils.DefaultSchedulerBuilder(
+                                jobGraph,
+                                
ComponentMainThreadExecutorServiceAdapter.forMainThread(),
+                                executorService)

Review Comment:
   direct executors services dont need to be shutdown since they arent backed 
by a thread pool.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to