alpreu opened a new pull request, #19377:
URL: https://github.com/apache/flink/pull/19377

   ## What is the purpose of the change
   
   Connectors should not depend on non-public API. To ensure that connectors 
satisfy this criteria we introduce a new ArchUnit test/rule for them.
   
   
   ## Brief change log
   
     - Added new ArchUnit rule checking connector dependencies
     - Updated ArchUnit violations
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - Run the test and check that violations are detected (see 
archunit-violations/d5f08b81-d148-4c1d-8666-d111e4b28600)
     - Manually introduce a violation by adding non-public API code to a 
connector and check if test detects it
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't 
know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / 
**JavaDocs** / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to