[
https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434429#comment-15434429
]
ASF GitHub Bot commented on FLINK-3874:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r76010171
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/JsonRowSerializationSchemaTest.java
---
@@ -35,19 +35,29 @@ public void testRowSerialization() throws IOException {
row.setField(1, true);
row.setField(2, "str");
+ Row resultRow = serializeAndDeserialize(fieldNames, fieldTypes,
row);
+ assertEqualRows(row, resultRow);
+ }
- JsonRowSerializationSchema serializationSchema = new
JsonRowSerializationSchema(fieldNames);
- JsonRowDeserializationSchema deserializationSchema = new
JsonRowDeserializationSchema(fieldNames, fieldTypes);
+ @Test
+ public void testSerializationOfTwoRows() throws IOException {
--- End diff --
Actually, the test I wanted to propose should serialize two rows (with same
schema) using the same `JsonRowSerializationSchema` and
`JsonRowDeserializationSchema` to make sure that there are no side effects.
This is also what happens in the table source.
> Add a Kafka TableSink with JSON serialization
> ---------------------------------------------
>
> Key: FLINK-3874
> URL: https://issues.apache.org/jira/browse/FLINK-3874
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Fabian Hueske
> Assignee: Ivan Mushketyk
> Priority: Minor
>
> Add a TableSink that writes JSON serialized data to Kafka.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
