infoverload commented on code in PR #19414:
URL: https://github.com/apache/flink/pull/19414#discussion_r847454084
##########
flink-end-to-end-tests/flink-stream-stateful-job-upgrade-test/src/main/java/org/apache/flink/streaming/tests/StatefulStreamJobUpgradeTestProgram.java:
##########
@@ -90,11 +92,13 @@ public static void main(String[] args) throws Exception {
private static void executeOriginalVariant(StreamExecutionEnvironment env,
ParameterTool pt)
throws Exception {
+ Duration maxOutOfOrderness = extractTimestamp(pt);
KeyedStream<Event, Integer> source =
env.addSource(createEventSource(pt))
.name("EventSource")
.uid("EventSource")
-
.assignTimestampsAndWatermarks(createTimestampExtractor(pt))
+ .assignTimestampsAndWatermarks(
+
WatermarkStrategy.forBoundedOutOfOrderness(maxOutOfOrderness))
Review Comment:
I tried various things including
`WatermarkStrategy.forBoundedOutOfOrderness(maxOutOfOrderness).createTimestampAssigner(createTimestampExtractor(pt)))`
and
`WatermarkStrategy.forBoundedOutOfOrderness(maxOutOfOrderness).withTimestampAssigner(createTimestampExtractor(pt)))`
but the types never seem to match.
Not sure how to reconcile the fact that it is looking for a
`TimestampAssignerSupplier` but getting a
`BoundedOutOfOrdernessTimestampExtractor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
