gyfora commented on code in PR #165:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/165#discussion_r848012796
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java:
##########
@@ -62,40 +64,42 @@ public static void updateForSpecReconciliationSuccess(
clonedSpec.getJob().setState(stateAfterReconcile);
}
reconciliationStatus.serializeAndSetLastReconciledSpec(clonedSpec);
+
reconciliationStatus.setReconciliationTimestamp(System.currentTimeMillis());
+ reconciliationStatus.setRolledBack(false);
}
public static void updateSavepointReconciliationSuccess(FlinkDeployment
flinkApp) {
ReconciliationStatus reconciliationStatus =
flinkApp.getStatus().getReconciliationStatus();
- reconciliationStatus.setSuccess(true);
- reconciliationStatus.setError(null);
+ flinkApp.getStatus().setError(null);
FlinkDeploymentSpec lastReconciledSpec =
reconciliationStatus.deserializeLastReconciledSpec();
lastReconciledSpec
.getJob()
.setSavepointTriggerNonce(flinkApp.getSpec().getJob().getSavepointTriggerNonce());
reconciliationStatus.serializeAndSetLastReconciledSpec(lastReconciledSpec);
+
reconciliationStatus.setReconciliationTimestamp(System.currentTimeMillis());
}
public static void updateForReconciliationError(FlinkDeployment flinkApp,
String err) {
- ReconciliationStatus reconciliationStatus =
flinkApp.getStatus().getReconciliationStatus();
- reconciliationStatus.setSuccess(false);
- reconciliationStatus.setError(err);
+ flinkApp.getStatus().setError(err);
}
public static void updateForSpecReconciliationSuccess(FlinkSessionJob
sessionJob) {
FlinkSessionJobReconciliationStatus reconciliationStatus =
sessionJob.getStatus().getReconciliationStatus();
- reconciliationStatus.setSuccess(true);
- reconciliationStatus.setError(null);
+ sessionJob.getStatus().setError(null);
FlinkSessionJobSpec clonedSpec = clone(sessionJob.getSpec());
reconciliationStatus.serializeAndSetLastReconciledSpec(clonedSpec);
}
public static void updateForReconciliationError(FlinkSessionJob
flinkSessionJob, String err) {
- FlinkSessionJobReconciliationStatus reconciliationStatus =
- flinkSessionJob.getStatus().getReconciliationStatus();
- reconciliationStatus.setSuccess(false);
- reconciliationStatus.setError(err);
+ flinkSessionJob.getStatus().setError(err);
+ }
+
+ public static void updateLastStableSpec(FlinkDeployment deployment) {
Review Comment:
I agree, I will move some if these simple utilities there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
