snuyanzin commented on code in PR #18487:
URL: https://github.com/apache/flink/pull/18487#discussion_r848689122


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java:
##########
@@ -1899,4 +1905,14 @@ public TableResult executeJsonPlan(String jsonPlan) {
         }
         return executeInternal(transformations, sinkIdentifierNames);
     }
+
+    public String[] showConnectors() {
+        return FactoryUtil.discoverFactories(userClassLoader).stream()
+                .filter(
+                        t ->
+                                t instanceof DynamicTableSourceFactory
+                                        || t instanceof 
DynamicTableSinkFactory)

Review Comment:
   @slinkydeveloper agree about `source/sink`, thanks for highlighting.
   A question about `format`': isn't it better to have a separate `show 
formats` for different formats?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to