[ 
https://issues.apache.org/jira/browse/FLINK-4363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435163#comment-15435163
 ] 

ASF GitHub Bot commented on FLINK-4363:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2400#discussion_r76085101
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/TaskExecutor.java
 ---
    @@ -94,12 +729,11 @@ public void notifyOfNewResourceManagerLeader(String 
newLeaderAddress, UUID newLe
                        if (newLeaderAddress != null) {
                                // the resource manager switched to a new leader
                                log.info("ResourceManager leader changed from 
{} to {}. Registering at new leader.",
    -                                           
resourceManagerConnection.getResourceManagerAddress(), newLeaderAddress);
    --- End diff --
    
    Why are these essentials RPC methods at the bottom. They should be moved to 
the top of the class.


> Implement TaskManager basic startup of all components in java
> -------------------------------------------------------------
>
>                 Key: FLINK-4363
>                 URL: https://issues.apache.org/jira/browse/FLINK-4363
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Zhijiang Wang
>            Assignee: Zhijiang Wang
>
> Similar with current {{TaskManager}},but implement initialization and startup 
> all components in java instead of scala.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to