fapaul commented on code in PR #19405: URL: https://github.com/apache/flink/pull/19405#discussion_r854077355
########## flink-end-to-end-tests/flink-end-to-end-tests-elasticsearch-common/src/main/java/org/apache/flink/streaming/tests/ElasticsearchDataReader.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.tests; + +import org.apache.flink.connector.testframe.external.ExternalSystemDataReader; + +import java.time.Duration; +import java.util.List; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** Elasticsearch data reader. */ +public class ElasticsearchDataReader + implements ExternalSystemDataReader<KeyValue<Integer, String>> { + private final ElasticsearchClient client; + private final String indexName; + private final int pageLength; + private int from; + + public ElasticsearchDataReader(ElasticsearchClient client, String indexName, int pageLength) { + this.client = checkNotNull(client); + this.indexName = checkNotNull(indexName); + this.pageLength = pageLength; + } + + @Override + public List<KeyValue<Integer, String>> poll(Duration timeout) { + client.refreshIndex(indexName); + // TODO: Tests are flaky without this small delay. Review Comment: You need to fix this because the current timeout can easily become flaky in the future did you try setting the refresh policy [1] in the emitters that every write needs to wait until the index is refreshed? [1] https://www.elastic.co/guide/en/elasticsearch/client/java-rest/current/java-rest-high-document-index.html#_optional_arguments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
