Aitozi commented on code in PR #168:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/168#discussion_r854663797
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java:
##########
@@ -204,12 +209,14 @@ private JarRunResponseBody runJar(
}
}
- private JarUploadResponseBody uploadJar(FlinkSessionJob sessionJob,
Configuration conf)
+ private JarUploadResponseBody uploadJar(
+ FlinkSessionJob sessionJob, FlinkDeployment sessionCluster,
Configuration conf)
throws Exception {
- Path path =
jarResolver.resolve(sessionJob.getSpec().getJob().getJarURI());
+ String targetDir = artifactManager.generateJarDir(sessionCluster,
sessionJob);
+ File jarFile =
artifactManager.fetch(sessionJob.getSpec().getJob().getJarURI(), targetDir);
Review Comment:
I also think about it, The good thing is that we can do no special thing for
the local filesystem when `fetch` and `delete` (If no copy, we may can't delete
after submit too). Do you think we need to handle the difference now ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
