echauchot commented on PR #19586: URL: https://github.com/apache/flink/pull/19586#issuecomment-1112142241
@zentol thanks for the review. I addressed all your comments. I left the review comments isolated to ease your second round of review. But in the end I think we should squash test code commits together leaving alone maybe [bac3ee51471798a0c3904872e1a347c8b3f64904](https://github.com/apache/flink/pull/19586/commits/bac3ee51471798a0c3904872e1a347c8b3f64904). For production code commits, I would avoid squashing them with test code commits as they add a new feature to the sinks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
