zentol commented on code in PR #19590: URL: https://github.com/apache/flink/pull/19590#discussion_r862824854
########## flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/maxwell/MaxwellJsonSerDerTest.java: ########## @@ -85,23 +83,23 @@ public void testDeserializationWithMetadata() throws Exception { TimestampFormat.ISO_8601); final SimpleCollector collector = new SimpleCollector(); deserializationSchema.deserialize(firstLine.getBytes(StandardCharsets.UTF_8), collector); - assertEquals(1, collector.list.size()); + assertThat(collector.list).hasSize(1); Consumer<RowData> consumer = row -> { Review Comment: ```suggestion assertThat(collector.list.get(0)) .satisfies(row -> { ``` ########## flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/maxwell/MaxwellJsonSerDerTest.java: ########## @@ -85,23 +83,23 @@ public void testDeserializationWithMetadata() throws Exception { TimestampFormat.ISO_8601); final SimpleCollector collector = new SimpleCollector(); deserializationSchema.deserialize(firstLine.getBytes(StandardCharsets.UTF_8), collector); - assertEquals(1, collector.list.size()); + assertThat(collector.list).hasSize(1); Consumer<RowData> consumer = row -> { - assertThat(row.getInt(0), equalTo(101)); - assertThat(row.getString(1).toString(), equalTo("scooter")); - assertThat(row.getString(2).toString(), equalTo("Small 2-wheel scooter")); - assertThat(row.getFloat(3), equalTo(3.14f)); - assertThat(row.getString(4).toString(), equalTo("test")); - assertThat(row.getString(5).toString(), equalTo("product")); - assertThat(row.getArray(6).getString(0).toString(), equalTo("id")); - assertThat(row.getTimestamp(7, 3).getMillisecond(), equalTo(1596684883000L)); + assertThat(row.getInt(0)).isEqualTo(101); + assertThat(row.getString(1).toString()).isEqualTo("scooter"); + assertThat(row.getString(2).toString()).isEqualTo("Small 2-wheel scooter"); + assertThat(row.getFloat(3)).isEqualTo(3.14f); + assertThat(row.getString(4).toString()).isEqualTo("test"); + assertThat(row.getString(5).toString()).isEqualTo("product"); + assertThat(row.getArray(6).getString(0).toString()).isEqualTo("id"); + assertThat(row.getTimestamp(7, 3).getMillisecond()).isEqualTo(1596684883000L); }; - consumer.accept(collector.list.get(0)); + assertThat(collector.list.get(0)).satisfies(consumer); Review Comment: ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org