Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2002#discussion_r76288290
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/common/io/compression/InflaterInputStreamFactory.java
 ---
    @@ -23,13 +23,12 @@
     import java.io.IOException;
     import java.io.InputStream;
     import java.util.Collection;
    -import java.util.zip.InflaterInputStream;
     
     /**
      * Creates a new instance of a certain subclass of {@link 
java.util.zip.InflaterInputStream}.
      */
     @Internal
    -public interface InflaterInputStreamFactory<T extends InflaterInputStream> 
{
    +public interface InflaterInputStreamFactory<T extends InputStream> {
    --- End diff --
    
    I think Greg raised a good point, the classname and comments should be 
adjusted as well. How about `DecompressingStreamFactory`, or 
`DecoratorStreamFactory` (if you want to keep it generic)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to