RocMarshal commented on code in PR #18983: URL: https://github.com/apache/flink/pull/18983#discussion_r865949794
########## flink-yarn/src/test/java/org/apache/flink/yarn/RegisterApplicationMasterResponseReflectorTest.java: ########## @@ -125,24 +119,22 @@ public void testDoesntCallGetSchedulerResourceTypesMethodIfAbsent() { registerApplicationMasterResponseReflector.getSchedulerResourceTypeNamesUnsafe( new Object()); - assertFalse(schedulerResourceTypeNames.isPresent()); + assertThat(schedulerResourceTypeNames).isNotPresent(); } @Test - public void testGetSchedulerResourceTypesMethodReflectiveHadoop26() { + void testGetSchedulerResourceTypesMethodReflectiveHadoop26() { assumeTrue( + isHadoopVersionGreaterThanOrEquals(2, 6), Review Comment: Done. ########## flink-yarn/src/test/java/org/apache/flink/yarn/RegisterApplicationMasterResponseReflectorTest.java: ########## @@ -81,28 +75,28 @@ public void testDoesntCallGetContainersFromPreviousAttemptsMethodIfAbsent() { registerApplicationMasterResponseReflector.getContainersFromPreviousAttemptsUnsafe( new Object()); - assertThat(containersFromPreviousAttemptsUnsafe, empty()); + assertThat(containersFromPreviousAttemptsUnsafe).isEmpty(); } @Test - public void testGetContainersFromPreviousAttemptsMethodReflectiveHadoop22() { + void testGetContainersFromPreviousAttemptsMethodReflectiveHadoop22() { assumeTrue( + isHadoopVersionGreaterThanOrEquals(2, 2), Review Comment: Done. ########## flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/active/ResourceManagerDriverTestBase.java: ########## @@ -39,12 +38,10 @@ import java.util.concurrent.TimeUnit; import java.util.function.Supplier; -import static org.hamcrest.Matchers.is; -import static org.junit.Assert.assertThat; +import static org.assertj.core.api.Assertions.assertThat; /** Common test cases for implementations of {@link ResourceManagerDriver}. */ -public abstract class ResourceManagerDriverTestBase<WorkerType extends ResourceIDRetrievable> - extends TestLogger { +public abstract class ResourceManagerDriverTestBase<WorkerType extends ResourceIDRetrievable> { Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org