haizhou-zhao commented on code in PR #19645:
URL: https://github.com/apache/flink/pull/19645#discussion_r866406450
##########
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/GenericRecordAvroTypeInfo.java:
##########
@@ -104,10 +105,15 @@ public boolean canEqual(Object obj) {
}
private void writeObject(ObjectOutputStream oos) throws IOException {
- oos.writeUTF(schema.toString());
+ byte[] schemaStrInBytes =
schema.toString(false).getBytes(StandardCharsets.UTF_8);
Review Comment:
Good catch. I wasn't previously thinking about state restoring.
I think type serializer does need to be checkpointed and restored (code
[link](https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/state/StateSerializerProvider.java#L99))
I'm less sure about how type info serialization is used as I didn't manage
to find a code reference for its usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
