[
https://issues.apache.org/jira/browse/FLINK-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438875#comment-15438875
]
ASF GitHub Bot commented on FLINK-3950:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2374#discussion_r76410471
--- Diff:
flink-metrics/flink-metrics-dropwizard/src/test/java/org/apache/flink/dropwizard/metrics/DropwizardMeterWrapperTest.java
---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.dropwizard.metrics;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+public class DropwizardMeterWrapperTest {
+ private static final double DELTA = 0.0001;
+
+ @Test
+ public void testWrapper() {
+ com.codahale.metrics.Meter dropwizardMeter =
mock(com.codahale.metrics.Meter.class);
+ when(dropwizardMeter.getOneMinuteRate()).thenReturn(1.0);
+ when(dropwizardMeter.getCount()).thenReturn(100L);
+
+ DropwizardMeterWrapper wrapper = new
DropwizardMeterWrapper(dropwizardMeter);
+
+ assertEquals(1.0, wrapper.getRate(), DELTA);
--- End diff --
this is minor, but i don't think we need a constant if it is only used once.
> Add Meter Metric Type
> ---------------------
>
> Key: FLINK-3950
> URL: https://issues.apache.org/jira/browse/FLINK-3950
> Project: Flink
> Issue Type: Sub-task
> Components: Core
> Reporter: Stephan Ewen
> Assignee: Ivan Mushketyk
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
