Aitozi commented on code in PR #203:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/203#discussion_r870094286
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkControllerConfig.java:
##########
@@ -37,4 +37,9 @@ public FlinkControllerConfig(Reconciler<CR> reconciler,
Set<String> watchedNames
public Set<String> getNamespaces() {
return watchedNamespaces;
}
+
+ @Override
+ public Set<String> getEffectiveNamespaces() {
Review Comment:
This PR change the behavior of the effectiveNamespaces, it will make the
webhook and the operator watch the same collection of the namespace.
Previously, the operator will use the internal (java-operator-sdk's) logic
to generate the effective watched namespace, it may be inconsistent the
webhook's.
After this, we can easily create `InformerManger` in the webhook module by
using the watchedNamespace generated by the config or environments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
