gyfora commented on code in PR #212:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/212#discussion_r873163697
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentController.java:
##########
@@ -125,13 +129,13 @@ public UpdateControl<FlinkDeployment>
reconcile(FlinkDeployment flinkApp, Contex
metricManager.onUpdate(flinkApp);
statusHelper.patchAndCacheStatus(flinkApp);
return ReconciliationUtils.toUpdateControl(
- configManager.getOperatorConfiguration(), flinkApp, true);
+ configManager.getOperatorConfiguration(), flinkApp,
previousDeployment, true);
}
private void handleDeploymentFailed(FlinkDeployment flinkApp,
DeploymentFailedException dfe) {
LOG.error("Flink Deployment failed", dfe);
flinkApp.getStatus().setJobManagerDeploymentStatus(JobManagerDeploymentStatus.ERROR);
- flinkApp.getStatus().getJobStatus().setState(JobStatus.FAILED.name());
+
flinkApp.getStatus().getJobStatus().setState(JobStatus.RECONCILING.name());
Review Comment:
Yes, setting it FAILED interferes with the logic around checking
globallTerminalState which should signal that we have actually observed the job
in a globally terminal state including savepoint/checkpoint info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
