[GitHub] [flink-table-store] openinx commented on a diff in pull request #126: [FLINK-27678] Support append-only table for file store.

[GitBox]

openinx commented on code in PR #126:
URL: https://github.com/apache/flink-table-store/pull/126#discussion_r876574729


##########
flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSourceSplitReader.java:
##########
@@ -203,10 +209,21 @@ private class FileStoreRecordIterator implements 
BulkFormat.RecordIterator<RowDa
                         .orElse(null);
 
         private FileStoreRecordIterator() {
-            this.rowDataSupplier =
-                    valueCountMode
-                            ? new ValueCountRowDataSupplier(this::nextKeyValue)
-                            : new 
PrimaryKeyRowDataSupplier(this::nextKeyValue);
+            switch (writeMode) {
+                case APPEND_ONLY:
+                    this.rowDataSupplier = new 
AppendOnlyRowDataSupplier(this::nextKeyValue);

Review Comment:
   Looks like we could just reuse the `PrimaryKeyRowDataSupplier` although its 
key is always a dummy empty key for an append only table. Let me revert this 
changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org